Skip to content

Conversation

@tokoko
Copy link
Contributor

@tokoko tokoko commented Dec 24, 2025

Moves dev extras to dependency-groups

@tokoko tokoko requested a review from nielspardon December 24, 2025 21:34
write_to = "src/substrait/_version.py"

[project.optional-dependencies]
extensions = ["antlr4-python3-runtime", "pyyaml"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether we still need this set of optional dependencies given that they are also part of the dev dependency group. Further, shouldn't those be default dependencies since we can assume most people with non-trivial use cases will want to use the extensions in some form?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea was that it's likely only necessary for producers, not consumers, see here. I don't have strong opinions. but starting from extra felt safer.

Copy link
Member

@nielspardon nielspardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tokoko tokoko merged commit 799b8a9 into substrait-io:main Jan 5, 2026
20 checks passed
@tokoko tokoko deleted the dependency-groups branch January 5, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants